Backport crash fixes to v3.7.x#27793
Merged
ksunden merged 5 commits intomatplotlib:v3.7.xfrom Feb 15, 2024
Merged
Conversation
This is a bunch of backports joined into one, as cibuildwheel 2.16.5 fixes a bug when building on Windows.
Member
|
Test failures are because #27624 was not backported but pytest v8 is being used. We can either add that to the backports or pin pytest on this branch. |
tacaswell
approved these changes
Feb 15, 2024
Member
Author
|
Hmm, it seems like Python 3.8 and Pytest 8's new context manager setup isn't working well together for some reason. |
Member
|
Maybe we should pin pytest back to less than 8 for this branch instead? It would be less code changes. |
Member
|
https://docs.python.org/3/whatsnew/3.10.html#parenthesized-context-managers I'm confused as to why it works on 3.9, though... using parens in a |
ksunden
reviewed
Feb 15, 2024
Prepare for Pytest v8 (cherry picked from commit ed41aea) Co-authored-by: Kyle Sunden <git@ksunden.space>
187c057 to
e97c7f3
Compare
dstansby
approved these changes
Feb 15, 2024
wavebyrd
pushed a commit
to wavebyrd/matplotlib
that referenced
this pull request
Mar 13, 2026
Backport crash fixes to v3.7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Backports #27755 for the macOS crash, #27785 for PGF on Windows, and #26689 just to make the previous backport easier.
PR checklist