Skip to content

Remove remaining deprecations from 3.5#24948

Merged
oscargus merged 6 commits intomatplotlib:mainfrom
QuLogic:remove-deprecations
Jan 12, 2023
Merged

Remove remaining deprecations from 3.5#24948
oscargus merged 6 commits intomatplotlib:mainfrom
QuLogic:remove-deprecations

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Jan 11, 2023 •
edited
Loading

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@tacaswell tacaswell added this to the v3.7.0 milestone Jan 11, 2023
@tacaswell tacaswell marked this pull request as ready for review January 11, 2023 22:21
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 11, 2023

I'm going to rebase due to get then updated CI settings on all the platforms (unclear why GHA is working, but azure is failing?).

@tacaswell tacaswell force-pushed the remove-deprecations branch from 666694d to 95814db Compare January 11, 2023 22:55
@QuLogic QuLogic force-pushed the remove-deprecations branch from 95814db to a5d95fe Compare January 12, 2023 03:54
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 12, 2023
@oscargus oscargus merged commit 244a01c into matplotlib:main Jan 12, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 12, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 12, 2023
@oscargus @meeseeksmachine
Backport PR matplotlib#24948: Remove remaining deprecations from 3.5
bdf8047
@QuLogic QuLogic deleted the remove-deprecations branch January 12, 2023 21:00
@oscargus
Copy link
Copy Markdown
Member

oscargus commented Jan 12, 2023 •
edited
Loading

Seems to be four remaining...

matplotlib/axes/_base.py:                    '3.5', name=_name,
matplotlib/backends/backend_webagg_core.py:    cursor = _api.deprecate_privatize_attribute("3.5")
matplotlib/colorbar.py:    @_api.delete_parameter("3.5", "update_ticks")
matplotlib/colorbar.py:    @_api.delete_parameter("3.5", "update_ticks")

But probably no big deal.

@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Jan 12, 2023 •
edited
Loading

Ah, good catches. I see, I only looked for deprecate and not those others.

oscargus added a commit that referenced this pull request Jan 12, 2023
@oscargus
Merge pull request #24961 from meeseeksmachine/auto-backport-of-pr-24…
4a2acf5 
…948-on-v3.7.x

Backport PR #24948 on branch v3.7.x (Remove remaining deprecations from 3.5)
@ksunden ksunden mentioned this pull request Jan 31, 2023
Merged
6 tasks
@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksunden ksunden ksunden approved these changes

@oscargus oscargus oscargus approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@QuLogic @tacaswell @oscargus @ksunden