ENH: Add warning for SymLogScale when values in linear scale range - #24555
Merged
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
timhoffm
reviewed
Nov 28, 2022
timhoffm
approved these changes
Nov 28, 2022
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Member
|
Thank you @parthpankajtiwary and congratulations on your first merged Matplotlib PR 🎉 I hope we hear from you again. |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jun 14, 2023
…mlog-warn" This reverts commit 041d4e0, reversing changes made to fbfa28d. Closes matplotlib#26118
QuLogic
added a commit
that referenced
this pull request
Jun 15, 2023
Revert "Merge pull request #24555 from parthpankajtiwary/symlog-warn"
1 task
melissawm
pushed a commit
to melissawm/matplotlib
that referenced
this pull request
Jun 15, 2023
…mlog-warn" This reverts commit 041d4e0, reversing changes made to fbfa28d. Closes matplotlib#26118
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jun 29, 2023
…4555 from parthpankajtiwary/symlog-warn"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The pull request addresses a need for generating a warning when a SymLogScale receives values that are all in the linear regime. The PR includes a baseline implementation as discussed in #24550. Some optional enhancements are in consideration.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst