Conversation
story645
approved these changes
Sep 18, 2022
Member
Member
|
When I find these; I fix the PR titles as well so it doesn't happen again. Slightly ironic that this PR title has a typo also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
These make pre-commit fail with spellcheck error.
While one ne could argue that we should keep the literal message including the typo, I think it is ok to correct this here: Logical: The PR numbers are stated here, so the PR title not needed as an ID, but rather a description. Also from a practical point of view, it's simpler to fix this than to teach pre-commit to ignore the typo.
Note: This goes directly into the 3.6 branch. The merge #23918 should be rebased on this.