BUG FIX for Pull Request #2275: Fix incorrect function calls#2326
Conversation
|
Would be helpful to get feedback from @mspacek if he has anything to add since he made the original PR. |
|
I can't test this myself since I don't use PySide, but this looks like exactly the right fix. |
|
This is a fix for issue #2318 |
|
@tacaswell, can you confirm that this fix worked for you? I know it does for me... |
|
I should have added that I tested this with the latest versions of PySide and PyQt4 |
|
@pmarshwx thanks for that. I've finally got PySide and PyQt4 installed side by side. This fixes the error from PySide on import, but the figure editor still raises an AttributeError for |
|
Admittedly, I did not test my submission against the PyQt v1 API. Thanks for catching that. |
In PR #2275, all the individual Qt functions were changed from being imported individually to being referenced from their parent QtCore or QtGui module. Unfortunately, this pull request accidentally kept pyqtSignature and pyqtProperty (which were aliased Qt calls) instead of utilizing the correct underlying Qt calls. This pull request changes the QtCore.pyqtSignature and QtCore.pyqtProperty calls from PR #2275 to the correct QtCore.Slot and QtCore.Property calls.