Fix Tk error when updating toolbar checkbutton images#22841
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Apr 14, 2022
Merged
Fix Tk error when updating toolbar checkbutton images#22841QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
tacaswell
approved these changes
Apr 13, 2022
Member
tacaswell
left a comment
There was a problem hiding this comment.
Code looks reasonable, but someone who has a dark-themed desktop should manually test this before it gets merged!
richardsheridan
approved these changes
Apr 14, 2022
Contributor
richardsheridan
left a comment
There was a problem hiding this comment.
I manually checked the dpi change error and the dark-mode behavior and it looks good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #22836 introduced in #22163
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).