Demonstrate inset_axes in scatter_hist example.#21283
Merged
story645 merged 1 commit intomatplotlib:masterfrom Oct 16, 2021
Merged
Demonstrate inset_axes in scatter_hist example.#21283story645 merged 1 commit intomatplotlib:masterfrom
story645 merged 1 commit intomatplotlib:masterfrom
Conversation
Member
|
it is a valid way/I abuse inset axes a lot/I think it's okay since you're not removing the other one ways to do it - though I wonder then if there should be a top line explicit
For each method so it doesn't read like 5 ways to do the same thing. |
Contributor
Author
|
Reworded. |
jklymak
reviewed
Oct 15, 2021
Member
jklymak
left a comment
There was a problem hiding this comment.
Looks great to me other than a couple of minor suggestions below. Thanks!
Comment on lines
+87
to
+89
| # Despite its name, `~.Axes.inset_axes` can also be used to position marginals | ||
| # *outside* the main axes. The advantage of doing so is that the aspect ratio | ||
| # of the main axes can be fixed, regardless of the figure size. |
Member
There was a problem hiding this comment.
Suggested change
| # Despite its name, `~.Axes.inset_axes` can also be used to position marginals | |
| # *outside* the main axes. The advantage of doing so is that the aspect ratio | |
| # of the main axes can be fixed, regardless of the figure size. | |
| # `~.Axes.inset_axes` can be used to position marginals | |
| # *outside* the main axes. The advantage of doing so is that the aspect ratio | |
| # of the main axes can be fixed, and the marginals will always be drawn relative | |
| # to the position of the axes. |
Comment on lines
+103
to
+104
| ax_histx = ax.inset_axes([0, 1.05, 1, 0.25], sharex=ax) | ||
| ax_histy = ax.inset_axes([1.05, 0, 0.25, 1], sharey=ax) |
Member
There was a problem hiding this comment.
You uses 2/7 before = 0.285. Is there a reason to use 0.25 here? Probably insignificant, but maybe change them to be the same?
Contributor
Author
There was a problem hiding this comment.
switched to 4:1 everywhere.
jklymak
approved these changes
Oct 15, 2021
story645
approved these changes
Oct 15, 2021
Member
story645
left a comment
There was a problem hiding this comment.
style nits, can be merged w/ or w/o changes
| toolkit is shown in the | ||
| :doc:`/gallery/axes_grid1/scatter_hist_locatable_axes` example. | ||
| :doc:`/gallery/axes_grid1/scatter_hist_locatable_axes` example. Finally, it is | ||
| also possible to simply position all axes in absolute coordinates using |
Member
There was a problem hiding this comment.
Suggested change
| also possible to simply position all axes in absolute coordinates using | |
| also possible to position all axes in absolute coordinates using |
timhoffm
reviewed
Oct 16, 2021
|
|
||
| * the axes positions are defined in terms of rectangles in figure coordinates | ||
| * the axes positions are defined via a gridspec | ||
| * the axes positions are defined via a gridspec; |
Member
There was a problem hiding this comment.
maybe use
.. contents::
:local:
to have links.
| @@ -121,5 +119,6 @@ def scatter_hist(x, y, ax, ax_histx, ax_histy): | |||
| # - `matplotlib.figure.Figure.add_axes` | |||
Member
There was a problem hiding this comment.
Suggested change
| # - `matplotlib.figure.Figure.add_axes` |
not used anymore.
Currently, the scatter_hist example needs to force the main axes to be square by carefully adjusting the figure size -- shared axes and fixed aspects don't work well together (and manually resizing the figure shows that the aspect is indeed not fixed). In fact, the scatter_hist_locatable_axes example explicitly states that the advantage of using axes_grid1 is to allow the aspect to be fixed. I realized that one can also use inset_axes to position the marginals axes relative to the main axes *and* support a fixed aspect ratio for the main axes. Perhaps this can be considered as a slight API abuse, but I think this is a solution for a real limitation; the question is whether we want to promote this use?
Contributor
Author
|
thanks, all comments handled |
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Demonstrate inset_axes in scatter_hist example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the scatter_hist example needs to force the main axes to be
square by carefully adjusting the figure size -- shared axes and fixed
aspects don't work well together (and manually resizing the figure shows
that the aspect is indeed not fixed). In fact, the
scatter_hist_locatable_axes example explicitly states that the advantage
of using axes_grid1 is to allow the aspect to be fixed.
I realized that one can also use inset_axes to position the marginals
axes relative to the main axes and support a fixed aspect ratio for
the main axes. Perhaps this can be considered as a slight API abuse,
but I think this is a solution for a real limitation; the question is
whether we want to promote this use?
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).