Skip to content

Ignore errors trying to delete make_release_tree.#20869

Merged
jkseppan merged 1 commit into
matplotlib:masterfrom
QuLogic:fix-setup
Aug 21, 2021
Merged

Ignore errors trying to delete make_release_tree.#20869
jkseppan merged 1 commit into
matplotlib:masterfrom
QuLogic:fix-setup

Conversation

@QuLogic

@QuLogic QuLogic commented Aug 21, 2021

Copy link
Copy Markdown
Member

PR Summary

Which apparently happens in Fedora's automated build requirement generator.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Which apparently happens in Fedora's automated build requirement
generator.
@QuLogic QuLogic added the Build label Aug 21, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 21, 2021
@timhoffm

Copy link
Copy Markdown
Member

May be a temporary fix. Note however that distutils will be deprecated in 3.10 https://www.python.org/dev/peps/pep-0632/, so we need a different approach anyway.

@QuLogic

QuLogic commented Aug 21, 2021

Copy link
Copy Markdown
Member Author

Yes, hence #20437, but setuptools does not yet completely replace distutils pypa/setuptools#2698

We may have to go some other way entirely, maybe more declarative or some such.

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, this fixes it.

@jkseppan
jkseppan merged commit ca275dc into matplotlib:master Aug 21, 2021
@QuLogic
QuLogic deleted the fix-setup branch August 23, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants