Deprecate @pytest.mark.style(...).#20543
Merged
Merged
Conversation
timhoffm
approved these changes
Jun 28, 2021
QuLogic
approved these changes
Jun 29, 2021
QuLogic
requested changes
Jun 29, 2021
QuLogic
left a comment
Member
There was a problem hiding this comment.
Tests say that you missed one usage, and that the deprecation is broken.
`@mpl.style.context` can be used in the same way (and is just as greppable), but doesn't require any support from the pytest machinery.
Contributor
Author
|
Thanks, should be fixed now (crossed PR and all...). |
7 tasks
QuLogic
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mpl.style.contextcan be used in the same way (and is just asgreppable), but doesn't require any support from the pytest machinery.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).