Dedupe some box anchoring code between legend.py and offsetbox.py.#20524
Merged
Conversation
timhoffm
approved these changes
Jun 27, 2021
Member
timhoffm
left a comment
There was a problem hiding this comment.
+/- optional changes.
On a more general note, it feels wrong that legend needs to explicitly handle locating. Shouldn't a legend be some subclass of an anchored box (I'm not very familiar with that part of the library, so I don't know which class exactly)?
Contributor
Author
|
It's probably possible to make legend reuse more of the offsetbox code, but there'd need to be quite a bit of backcompat/surgery due to different attribute names, etc. so that'd be a separate project. |
Member
|
Did you not push the optional changes? |
Contributor
Author
|
oopsie. |
QuLogic
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).