Skip to content

Text rotation patch#19114

Closed
Alex-Carter01 wants to merge 3 commits intomatplotlib:mainfrom
Alex-Carter01:text-rotation-patch
Closed

Text rotation patch#19114
Alex-Carter01 wants to merge 3 commits intomatplotlib:mainfrom
Alex-Carter01:text-rotation-patch

Conversation

@Alex-Carter01
Copy link
Copy Markdown

@Alex-Carter01 Alex-Carter01 commented Dec 14, 2020

PR Summary

Resolves issue #13044. Fixing calculation error of Y-offset for specific rotation mode of text. This pull also includes a proposed minimal test (based off the original bug report).

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@Alex-Carter01
add comparison image for rotation test in test_text
8a6dc24
@Alex-Carter01
patch to rotation error in anchor, center_baseline mode
7c939d9 
fix to error in calculation of Y offset in text rotation.
todo: test and test baseline
@Alex-Carter01
add corresponding test for proposed patch to text rotation
762c32e 
see baseline_images for corresponding baseline
@jklymak
Copy link
Copy Markdown
Member

jklymak commented Dec 15, 2020

Thanks a lot for the pull request! Unfortunately this broke some existing tests in test_text.py, so this isn't compatible with the existing behaviour. So you will either have to change the old tests and argue that they were wrong, or modify this....

@story645
Copy link
Copy Markdown
Member

story645 commented Apr 6, 2021

hey @Alex-Carter01, do you have any bandwidth to finish up this PR?

@timhoffm timhoffm mentioned this pull request Apr 7, 2021
Open
@jklymak jklymak marked this pull request as draft April 23, 2021 16:58
@WeatherGod
Copy link
Copy Markdown
Member

WeatherGod commented Apr 24, 2021

Oh, and we should double-check with the Cairo renderer, although I suspect it might have the same bug if this is happening at a layer above AGG/Cairo?

@safdarzareef safdarzareef mentioned this pull request Apr 24, 2021
Closed
7 tasks
@dstansby
Copy link
Copy Markdown
Member

dstansby commented Dec 18, 2021

Thanks for opening this PR. Unfortunately I don't think this is the correct fix. ymax1 - baseline / 2.0 seems to be the correct logic, putting the offset halfway between the baseline and ymax, so I think subtracting ymin1 is incorrect. As such I'm going to close this PR - if I've missed something feel free to comment and I will open it up again, and thanks again for the contribution.

@dstansby dstansby closed this Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: needs rebase status: needs revision status: orphaned PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Alex-Carter01 @jklymak @story645 @WeatherGod @dstansby