Disable mouseover info for NonUniformImage.#18728
Merged
Merged
Conversation
Currently NonUniformImage just inherits get_cursor_data from the base class, resulting in nonsensical cursor info. While properly implementing NonUniformImage.get_cursor_data would be better, at least we can disable cursor info in the meantime.
timhoffm
approved these changes
Oct 14, 2020
Member
|
You may want to create a ticket for the mouse over. I think that's a good first issue. |
Contributor
Author
|
that's already tracked at #18652. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently NonUniformImage just inherits get_cursor_data from the base
class, resulting in nonsensical cursor info. While properly
implementing NonUniformImage.get_cursor_data would be better, at least
we can disable cursor info in the meantime.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).