Skip to content

Update barchart_demo.#16807

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:barchart_demo
Mar 18, 2020
Merged

Update barchart_demo.#16807
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:barchart_demo

Conversation

@anntzer

@anntzer anntzer commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

Replace "meta information" by "units" (which describes what it is
better).

Capitalize comments.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Update barchart_demo.
d13608e 
Replace "meta information" by "units" (which describes what it is
better).

Capitalize comments.
@anntzer anntzer added this to the v3.3.0 milestone Mar 17, 2020
tacaswell
tacaswell approved these changes Mar 18, 2020
View reviewed changes

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contingent on CI passing.

@tacaswell

tacaswell commented Mar 18, 2020

Copy link
Copy Markdown
Member

And apparently I can't re-trigger circle anymore?

@timhoffm

timhoffm commented Mar 18, 2020

Copy link
Copy Markdown
Member

CircleCI failure is due to the pillow intersphinx inventory not being reachable. I've noted that this has been flaky in the last couple of days.

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://pillow.readthedocs.io/en/stable/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 502 Server Error: Bad Gateway for url: https://pillow.readthedocs.io/en/stable/objects.inv

@timhoffm timhoffm merged commit 71163e9 into matplotlib:master Mar 18, 2020
@anntzer anntzer deleted the barchart_demo branch March 18, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @tacaswell @timhoffm