Skip to content

Increase fontsize in inheritance graphs#15391

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
Psirus:fontsize_inheritance_graphs
Oct 11, 2019
Merged

Increase fontsize in inheritance graphs#15391
dstansby merged 1 commit into
matplotlib:masterfrom
Psirus:fontsize_inheritance_graphs

Conversation

@Psirus
Copy link
Copy Markdown
Contributor

@Psirus Psirus commented Oct 7, 2019 •
edited
Loading

This closes #15109.

The diagram in question goes from (click on images to see actual size in sphinx, the Github PR view rescales them)
inheritance-baace9733e25a3aea26ce118da06767ea5ea372e
to
inheritance-84ea9a23f67b6f8091bb1887c23eb7780337cb16
which isn't ideal, but the best I achieved given the width constraints.

@jklymak
Copy link
Copy Markdown
Member

jklymak commented Oct 7, 2019

If the inheritance is direct, any chance we can shorten the collections.PathCollection to c.PathCollection w/o loss of understanding?

@Psirus
Copy link
Copy Markdown
Contributor Author

Psirus commented Oct 7, 2019

So there is a inheritance_alias option, but I can't get it to work. 🤷‍♂️ Additionally, it would be global, the collections module would be shortened to c in every diagram, not just this one. Currently, this is the only diagram where collections (as a module name) appears.

@jklymak
Copy link
Copy Markdown
Member

jklymak commented Oct 7, 2019

OK, sorry, didn't realize the diagram came from sphinx and not us...

@jklymak
Copy link
Copy Markdown
Member

jklymak commented Oct 7, 2019

This seems better, is collections really the worst offender? Did you look at the other places we use inheritance diagrams?

@Psirus
Copy link
Copy Markdown
Contributor Author

Psirus commented Oct 8, 2019

Yes, I did look at all the inheritance diagrams. collections is the worst offender imho, but there was a big improvement from
inheritance-2670f9102ffacb31874575075e2b9abd67b80a04
to this
inheritance-72fdad6e2fcef7304144a035ceebcc60d0fb7889
as well. There are a couple more examples like this.

dstansby
dstansby approved these changes Oct 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks like a nice improvement, thanks for submitting a PR!

@jklymak
Copy link
Copy Markdown
Member

jklymak commented Oct 9, 2019

yes thanks! Looks like the failing test is a flake8 error in conf.py. Please fix before merging....

@dstansby dstansby added this to the v3.2.0 milestone Oct 11, 2019
@dstansby dstansby merged commit 56b98db into matplotlib:master Oct 11, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 11, 2019
@dstansby
Backport PR matplotlib#15391: Increase fontsize in inheritance graphs
a145212
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 11, 2019
Merged
timhoffm added a commit that referenced this pull request Oct 11, 2019
@timhoffm
Merge pull request #15405 from meeseeksmachine/auto-backport-of-pr-15…
73b3a8f 
…391-on-v3.2.x

Backport PR #15391 on branch v3.2.x (Increase fontsize in inheritance graphs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstansby dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

matplotlib.collections inheritance diagram small/blurry

3 participants

@Psirus @jklymak @dstansby