Autodetect some transform properties. - #14922
Merged
Merged
Conversation
QuLogic
approved these changes
Aug 2, 2019
Member
|
How often do we check these in the code, iirc the the performance cost of properties over attribute access is sizable. |
Member
|
This actually seems like a good case for |
Contributor
Author
|
Good point re |
timhoffm
reviewed
Aug 5, 2019
| - :attr:`is_separable` | ||
| - :attr:`has_inverse` | ||
| - :meth:`inverted` (if :attr:`has_inverse` is True) | ||
| - :attr:`is_separable` (defaults to True for 1d -> 1d transforms) |
Member
There was a problem hiding this comment.
Subclasses of this class should override the following members (at minimum):
Is not correct anymore for is_separable and has_inverse. Either rephrase or put those two in a separate block.
- 1d transforms are always separable, no need to repeat `is_separable = True` again and again. - If a subclass overrides `inverted()` then it is most likely invertible (though not always), no need to repeat `has_inverse = True` again and again (but subclasses can always override to `has_inverse = False`).
timhoffm
approved these changes
Aug 5, 2019
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_separable = Trueagain and again.inverted()then it is most likely invertible(though not always), no need to repeat
has_inverse = Trueagain andagain (but subclasses can always override to
has_inverse = False).PR Summary
PR Checklist