Skip to content

mpl_toolkits style fixes.#14529

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:toolkitstyle
Jun 12, 2019
Merged

mpl_toolkits style fixes.#14529
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:toolkitstyle

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Jun 11, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.2.0 milestone Jun 11, 2019
dd = np.arctan2(yy1b-yy1a, xx1b-xx1a) # angle normal
dd2 = np.arctan2(yy2b-yy2a, xx2b-xx2a) # angle tangent
mm = (yy1b-yy1a == 0) & (xx1b-xx1a == 0) # mask where dd1 is not defined
mm = (yy1b == yy1a) & (xx1b == xx1a) # mask where dd1 not defined
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mm = (yy1b == yy1a) & (xx1b == xx1a) # mask where dd1 not defined
mm = (yy1b == yy1a) & (xx1b == xx1a) # mask where dd is not defined

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, fixed

@timhoffm timhoffm merged commit ef3a17a into matplotlib:master Jun 12, 2019
@anntzer anntzer deleted the toolkitstyle branch June 12, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants