Simplify Qt tests.#14506
Merged
Merged
Conversation
In test_backend_qt, qt_key is basically a complicated way to access Qt modifier keys using nonstandard names that are not used anywhere but in the tests (ControlKey instead of Key_Control). Get rid of it and just use standard Qt modifier key names. Simplify the qt_module fixture as a consequence (just returning QtCore).
6 tasks
timhoffm
approved these changes
Jun 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test_backend_qt, qt_key is basically a complicated way to access Qt
modifier keys using nonstandard names that are not used anywhere but in
the tests (ControlKey instead of Key_Control). Get rid of it and just
use standard Qt modifier key names. Simplify the qt_module fixture as a
consequence (just returning QtCore).
PR Summary
PR Checklist