Skip to content

Remove the package_data.dlls setup.cfg entry.#14383

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:package_dlls
Jun 9, 2019
Merged

Remove the package_data.dlls setup.cfg entry.#14383
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:package_dlls

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented May 30, 2019

See changelog for details.

DLLs won't end up in the source tree unless one explicitly copies them
there, so let's assume that whoever does this knows what they're doing.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

See changelog for details.

DLLs won't end up in the source tree unless one explicitly copies them
there, so let's assume that whoever does this knows what they're doing.
@tacaswell tacaswell added this to the v3.2.0 milestone May 31, 2019
Copy link
Copy Markdown
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on @cgohlke not using this.

@cgohlke
Copy link
Copy Markdown
Contributor

cgohlke commented Jun 9, 2019

LGTM

@timhoffm timhoffm merged commit 29265dc into matplotlib:master Jun 9, 2019
@anntzer anntzer deleted the package_dlls branch June 9, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants