Make conversions of xrange()#10559
Closed
tropfcode wants to merge 4 commits into
Closed
Conversation
…tring Added RectangleSelector.geometry docstring
Remove import of xrange() and convert xrange() to range()
Import itertools and use itertools.count() to convert xrange() for Python3
Contributor
Author
|
Will redo PR on different branch. |
QuLogic
reviewed
Feb 21, 2018
| s_len = 0 | ||
| # todo: use Alex's xrange pattern from the cbook for efficiency | ||
| for (word, ind) in zip(seq, xrange(len(seq))): | ||
| for (word, ind) in zip(seq, range(len(seq))): |
Member
There was a problem hiding this comment.
This should use enumerate instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove imports of six.moves.xrange() and convert use of xrange() to range() or itertools.count() for Pythong3 compliance. This completes the first and third issues of #10556.
PR Checklist