You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @jbonzo, I'm facing a dependency deadlock due to the lint check failing against black (23.12.1). I need to merge the current PR to then update the black version to 24.4.2 as required by this PR, which wants a different linting style. Can we merge this PR even if the lint check doesn't pass, or is there a workaround to update the lint check that could resolve this issue? What are your thoughts on proceeding with a merge that doesn't pass the lint check?
Hey @jbonzo, I'm facing a dependency deadlock due to the lint check failing against black (23.12.1). I need to merge the current PR to then update the black version to 24.4.2 as required by this PR, which wants a different linting style. Can we merge this PR even if the lint check doesn't pass, or is there a workaround to update the lint check that could resolve this issue? What are your thoughts on proceeding with a merge that doesn't pass the lint check?
@justinpolygon Is there something preventing us from putting the comprehensive fix in this single PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to fix lint formatting issue with #658.