Skip to content

changed logic in parse subscription to handle class designation #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mickeyyawn wants to merge 2 commits into from
Closed

changed logic in parse subscription to handle class designation #559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0552d9
removed old method. oops.
mickeyyawn Nov 20, 2023
4b79944
moved from case to if statement
mickeyyawn Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions polygon/websocket/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,24 @@ async def _unsubscribe(self, topics: Union[List[str], Set[str]]):
self.json.dumps({"action": "unsubscribe", "params": subs})
)


@staticmethod
def _parse_subscription(s: str):
s = s.strip()
split = s.split(".")
if len(split) != 2:
logger.warning("invalid subscription:", s)
length = len(split)

if length < 2:
logger.warning("invalid subscription:", s)
return [None, None]
if length == 2:
return split[0], split[1]
if length == 3:
return split[0], split[1] + "." + split[2]
if length > 3:
logger.warning("invalid subscription:", s)
return [None, None]

return split

def subscribe(self, *subscriptions: str):
"""
Expand Down