Skip to content

Add Logger#184

Merged
clickingbuttons merged 3 commits into
masterfrom
logger
May 17, 2022
Merged

Add Logger#184
clickingbuttons merged 3 commits into
masterfrom
logger

Conversation

@clickingbuttons
Copy link
Copy Markdown
Contributor

@clickingbuttons clickingbuttons commented May 17, 2022

Make logs more extensible. Keep existing api of verbose. Logger can still be overridden by consumers via logging.getLogger('RESTClient') or logging.getLogger('WebsocketClient').

Logs look like this now:

2022-05-17 15:27:17,493 RESTClient DEBUG: _get /v2/aggs/ticker/AAPL/range/1/day/2022-04-04/2022-04-04 params {}
2022-05-17 15:29:30,465 WebSocketClient DEBUG: sub desired: T.AAPL
2022-05-17 15:29:30,466 WebSocketClient DEBUG: sub desired: T.AMZN
2022-05-17 15:29:30,466 WebSocketClient DEBUG: sub desired: T.*
2022-05-17 15:29:30,466 WebSocketClient DEBUG: sub undesired: T.*
2022-05-17 15:29:30,466 WebSocketClient DEBUG: closing
2022-05-17 15:29:30,466 WebSocketClient WARNING: no websocket open to close

@clickingbuttons clickingbuttons merged commit b43d39c into master May 17, 2022
@clickingbuttons clickingbuttons deleted the logger branch May 17, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Darcy-Linde Darcy-Linde Darcy-Linde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clickingbuttons @Darcy-Linde