Skip to content

test on windows/osx #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clickingbuttons merged 21 commits into from
May 11, 2022
Merged

test on windows/osx #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8b24668
test on windows/osx
clickingbuttons May 11, 2022
4a849a9
fix test paths for osx and windows
clickingbuttons May 11, 2022
5f364dd
style
clickingbuttons May 11, 2022
70526d3
only lint 3.10
clickingbuttons May 11, 2022
695097c
remove mac
clickingbuttons May 11, 2022
711c61e
replace : with ;
clickingbuttons May 11, 2022
c774709
windows hack
clickingbuttons May 11, 2022
d20b965
debugging
clickingbuttons May 11, 2022
15f13e0
only hack on windows
clickingbuttons May 11, 2022
57ffc83
more windows hacks
clickingbuttons May 11, 2022
c9a1400
pook
clickingbuttons May 11, 2022
2497a7d
Merge remote-tracking branch 'origin/master' into osx-window
clickingbuttons May 11, 2022
f3a8bf0
style
clickingbuttons May 11, 2022
c473334
fix static
clickingbuttons May 11, 2022
40a6777
more hacking
clickingbuttons May 11, 2022
58cd197
please pook
clickingbuttons May 11, 2022
2eb8593
windowsss
clickingbuttons May 11, 2022
c6b172c
style
clickingbuttons May 11, 2022
0891e1e
lint
clickingbuttons May 11, 2022
1cdcda9
remove base export
clickingbuttons May 11, 2022
0ff0741
Merge remote-tracking branch 'origin/master' into osx-window
clickingbuttons May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10']
python-version: ['3.10']
name: Lint ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v3
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@ permissions:
contents: read
jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
python-version: ['3.8', '3.9', '3.10']
name: Unit test ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
name: ${{ matrix.os }} Unit test ${{ matrix.python-version }}
steps:
- name: Windows hack
run: git config --system core.longpaths true
if: ${{ matrix.os == 'windows-latest' }}
- uses: actions/checkout@v3
- name: Setup Python
uses: actions/setup-python@v3
Expand Down
165 changes: 159 additions & 6 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions polygon/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
import os


base = "https://api.polygon.io"
env_key = "POLYGON_API_KEY"
BASE = "https://api.polygon.io"
ENV_KEY = "POLYGON_API_KEY"


class RESTClient(
Expand All @@ -33,12 +33,12 @@ class RESTClient(
):
def __init__(
self,
api_key: Optional[str] = os.getenv(env_key),
api_key: Optional[str] = os.getenv(ENV_KEY),
connect_timeout: float = 10.0,
read_timeout: float = 10.0,
num_pools: int = 10,
retries: int = 3,
base: str = base,
base: str = BASE,
verbose: bool = False,
):
super().__init__(
Expand Down
9 changes: 8 additions & 1 deletion polygon/rest/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,14 @@ def _get_params(
elif isinstance(val, datetime):
val = int(val.timestamp() * self.time_mult(datetime_res))
if val is not None:
params[argname.replace("_", ".")] = val
if (
argname.endswith("_lt")
or argname.endswith("_lte")
or argname.endswith("_gt")
or argname.endswith("_gte")
):
argname = argname.replace("_", ".")
params[argname] = val

return params

Expand Down
6 changes: 3 additions & 3 deletions polygon/rest/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
class SnapshotClient(BaseClient):
def get_snapshot_all(
self,
market_type: Optional[Union[str, SnapshotMarketType]] = "stocks",
market_type: Optional[Union[str, SnapshotMarketType]],
tickers: Optional[Union[str, List[str]]] = None,
params: Optional[Dict[str, Any]] = None,
raw: bool = False,
Expand All @@ -40,8 +40,8 @@ def get_snapshot_all(

def get_snapshot_direction(
self,
market_type: Optional[Union[str, SnapshotMarketType]],
direction: Union[str, Direction],
market_type: Optional[Union[str, SnapshotMarketType]] = "stocks",
params: Optional[Dict[str, Any]] = None,
raw: bool = False,
) -> Union[List[TickerSnapshot], HTTPResponse]:
Expand All @@ -67,8 +67,8 @@ def get_snapshot_direction(

def get_snapshot_ticker(
self,
market_type: Optional[Union[str, SnapshotMarketType]],
ticker: str,
market_type: Optional[Union[str, SnapshotMarketType]] = "stocks",
params: Optional[Dict[str, Any]] = None,
raw: bool = False,
) -> Union[TickerSnapshot, HTTPResponse]:
Expand Down
Loading