Repository navigation
Conversation
|
@xiehuanyi is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: master
cdbdc0122ab83b2b97560944bf009a22cfb78b05(18.1.1)Markdown flavor: n/a — JavaScript hooks API
Description
Expectation
Calling
parse(markdown, { async: true })should await composed hooks and honor an async hook returning false to use the previous provider.Result
Hook composition checks the instance default async flag instead of the active parse options. When async mode is enabled only on a parse call, an async hook passes a Promise into an earlier synchronous hook, or an async provider's false fallback is skipped. The parse rejects with errors such as
markdown.toUpperCase is not a function.What was attempted
Use the parse options already stored on the hooks object to select async composition. Add regressions for chained preprocess/postprocess hooks and an asynchronous parser-provider fallback while keeping the instance default synchronous.
Validation: all three regressions fail before the fix. Full
npm testpasses, including 1911 specification tests and 202 unit tests, build/docs, UMD/CJS smoke checks, types and lint.git diff --checkpasses.Discovery and implementation: automated OpenAI
gpt-6.1-solsource review, xhigh reasoning.Contributor
Committer