Skip to content

Commit 0100a82

Browse files
aignasaignas
authored
refactor(visibility)!: limit visibility of an internal library (bazel-contrib#1490)
This was arguably made too-visible previously and since all of the consumable symbols by the end users are re-exported via the //python:pip_bzl, we can keep everything that is in pip_install internal. This could be a breaking change for people who are depending on internal symbols or if they are using `whl_library` to create their own implementation of the `pip_repository` rule and are generating documentation internally. However, in that case they can apply a small patch to change the visibility of the `pip_repository_bzl` target.
1 parent c2a2f79 commit 0100a82

4 files changed

Lines changed: 6 additions & 237 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ A brief description of the categories of changes:
1919

2020
## Unreleased
2121

22+
### Changed
23+
24+
* Make `//python/pip_install:pip_repository_bzl` `bzl_library` target internal
25+
as all of the publicly available symbols (etc. `package_annotation`) are
26+
re-exported via `//python:pip_bzl` `bzl_library`.
27+
2228
### Fixed
2329

2430
* Skip aliases for unloaded toolchains. Some Python versions that don't have full

‎docs/BUILD.bazel‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ licenses(["notice"]) # Apache 2.0
2626
_DOCS = [
2727
"packaging",
2828
"pip",
29-
"pip_repository",
3029
"py_cc_toolchain",
3130
"py_cc_toolchain_info",
3231
# TODO @aignas 2023-10-09: move some of the example code from the `.bzl` files
@@ -94,16 +93,6 @@ stardoc(
9493
],
9594
)
9695

97-
stardoc(
98-
name = "pip-repository",
99-
out = "pip_repository.md.gen",
100-
input = "//python/pip_install:pip_repository.bzl",
101-
target_compatible_with = _TARGET_COMPATIBLE_WITH,
102-
deps = [
103-
"//python/pip_install:pip_repository_bzl",
104-
],
105-
)
106-
10796
stardoc(
10897
name = "py-console-script-binary",
10998
out = "py_console_script_binary.md.gen",

0 commit comments

Comments
 (0)