Fix #153 Cover image doesn't show up with epub in iBooks#237
Merged
marijnh merged 2 commits intomarijnh:masterfrom Nov 21, 2017
Merged
Fix #153 Cover image doesn't show up with epub in iBooks#237marijnh merged 2 commits intomarijnh:masterfrom
marijnh merged 2 commits intomarijnh:masterfrom
Conversation
Owner
|
Shouldn't that point at |
Author
|
You're absolutely right. I fixed that. |
Owner
|
Thanks. Merged. The epub on the website is in the process of being rebuilt. |
|
I still see the issue when downloading the ePub from the website and load it into iBooks. |
Owner
|
Is the meta tag there when you unzip the book? It should be. If it doesn't help, the problem diagnosis may have been wrong in the first place? |
|
I'll verify. One sec. |
|
Owner
|
Could you clarify? |
|
That is on Line 75 of the content.opf. When I manually pulled and compiled the file it worked just fine. |
Author
|
My bad. I think I was right in the first place. Attribute was indeed correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iBooks needs the following meta tag:
in
content.opfin order to display the cover.Fixes #153