Repository navigation
#4141 Use a presence check for Optional nested sources in update mappings - #4142
Open
jasper-vandemalle wants to merge 1 commit into
Open
jasper-vandemalle wants to merge 1 commit into
jasper-vandemalle wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4141
In an update mapping, an
Optionalnested source is guarded with!= nullbefore the forged update method is called. AnOptionalsource is normally notnull, soOptional.empty()never reaches theSET_TO_NULL/SET_TO_DEFAULTbranch: the existing target is kept, and anullnested target gets an empty new instance. The guard inUpdateWrappernow also checksisPresent()forOptionalsources.A
nullOptionalreference behaves as before, since that likely depends on the outcome of #4123 and #4128.