Define new enum ClassAccessibility#4071
Conversation
… declared accessibility.
… declared accessibility.
hduelme
left a comment
There was a problem hiding this comment.
@Chessray thanks for the adjustments.
One last thought: currently, DEFAULT is used to represent package-private visibility. Would something like PACKAGE_PRIVATE be more intuitive and make the intent clearer? Let me know what you think.
Out of curiosity, are you planning to use this feature mapstruct-spring-extensions?
I had this exact mental discussion and ended up with
I don't really see how. This influences the Mapper generation, not the Adapter. |
|
Nice addition @Chessray. From the point of our API, I personally find the |
@Chessray Good point. I think we should rename Accessibility.java too. |
Makes sense. Do you think we should adjust the examples in the extension? My thoughts were based on the original issue mentioning Spring. |
|
Thanks guys, this should be it now. @hduelme I'll take a look at the Spring Extension examples separately. Maybe I'll only mention it in the documentation. |
hduelme
left a comment
There was a problem hiding this comment.
@Chessray thanks for adjusting. The naming looks good to me now.
It seems like we currently don't enforce consistent enum formatting.
@filiphr I think the preferred formatting is to have spaces before and after enum constant parameters (e.g. PUBLIC( "public" )). Do you agree? Maybe we could add this rule to our Checkstyle configuration.
|
@Chessray Nice one. Thanks |
Define new enum
ClassAccessibilityfor controlling generated Mappers' declared accessibility.Fixes #2513.