Skip to content

Add support for JSpecify nullness annotations (#1243) #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiphr merged 11 commits into from
Apr 19, 2026
+3,063 −24
Merged

Add support for JSpecify nullness annotations (#1243) #4033

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4557780
Add support for JSpecify nullness annotations (#1243)
filiphr Apr 12, 2026
3f781e5
Fix JSpecify nullness edge cases and expand test coverage
filiphr Apr 13, 2026
3a7880d
Harden JSpecify nullness support and surface decisions
filiphr Apr 13, 2026
5af89e4
Make JSpecify test classes package-private
filiphr Apr 13, 2026
2b98223
Skip JSpecify @NonNull constructor-param error when assignment failed
filiphr Apr 13, 2026
f485467
Clean up JSpecify note messages and Javadoc accuracy
filiphr Apr 13, 2026
176784a
Fix JSpecify fixture filename casing for case-sensitive filesystems
filiphr Apr 13, 2026
b90a99f
Document JSpecify nullness annotation support
filiphr Apr 13, 2026
e808c28
Require every source-chain accessor to be @NonNull before skipping nu…
filiphr Apr 16, 2026
29e78a0
Add mapstruct.disableJSpecify option to opt out of JSpecify inference
filiphr Apr 16, 2026
01e6d5c
Document mapstruct.disableJSpecify in the processor options table
filiphr Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix JSpecify fixture filename casing for case-sensitive filesystems 
The test passed "withoutpackageinfo" (lowercase) as the variant but the
fixture file on disk is PackageNullMarkedMapperImpl_withoutPackageInfo.java
(PascalCase). macOS's case-insensitive filesystem matched them locally;
Linux CI (case-sensitive) could not find the fixture and failed.
  • Loading branch information
@filiphr
filiphr committed Apr 13, 2026
commit 176784ad83147561da7cfdd423064a6d6210921d
2 changes: 1 addition & 1 deletion processor/src/test/java/org/mapstruct/ap/test/nullcheck/jspecify/JSpecifyNullMarkedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ public void packageLevelNullMarkedWithoutPackageInfo() {
// Same classes and mapper as packageLevelNullMarked but WITHOUT @WithPackageInfo.
// Without the package-info.java being compiled, @NullMarked is not visible —
// unannotated types have unknown nullability and the ALWAYS strategy produces null checks.
generatedSource.addComparisonToFixtureFor( PackageNullMarkedMapper.class, "withoutpackageinfo" );
generatedSource.addComparisonToFixtureFor( PackageNullMarkedMapper.class, "withoutPackageInfo" );
}

}
Loading