Skip to content

#3943: Allow generation of methods with a sole argument of primitive type #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anenviousguest wants to merge 9 commits into
base: main
Choose a base branch
from
Open

#3943: Allow generation of methods with a sole argument of primitive type #3944

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
25865b6
#3943: Allow generation of methods with a sole argument of primitive …
anenviousguest Oct 15, 2025
53c7634
Merge branch 'refs/heads/main' into fix/3943
anenviousguest Oct 15, 2025
13d0c0d
Merge branch 'refs/heads/main' into fix/3943
anenviousguest Feb 28, 2026
9238c8a
#3943: Added test according to PR feedback.
anenviousguest Feb 28, 2026
78bf465
#3943: Added test according to PR feedback.
anenviousguest Feb 28, 2026
daa1c2d
#3943: Added negative test.
anenviousguest Feb 28, 2026
a6544a8
#3943: Removed an unwanted comment.
anenviousguest Feb 28, 2026
ac66f90
#3943: Fixed checkstyle issues.
anenviousguest Feb 28, 2026
d815a77
#3943: Fixed alternative error line number.
anenviousguest Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'refs/heads/main' into fix/3943 
# Conflicts:
#	processor/src/main/java/org/mapstruct/ap/internal/processor/MethodRetrievalProcessor.java
  • Loading branch information
@anenviousguest
anenviousguest committed Oct 15, 2025
commit 53c76348f62f74617c9b0040d093681a818b6af8
5 changes: 5 additions & 0 deletions processor/src/main/java/org/mapstruct/ap/internal/processor/MethodRetrievalProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,11 @@ private boolean checkParameterAndReturnType(ExecutableElement method, List<Param
return false;
}

if ( !parameterType.isIterableOrStreamType() && resultType.isArrayType() ) {
messager.printMessage( method, Message.RETRIEVAL_NON_ITERABLE_TO_ARRAY );
return false;
}

for ( Type typeParameter : parameterType.getTypeParameters() ) {
if ( typeParameter.hasSuperBound() ) {
messager.printMessage( method, Message.RETRIEVAL_WILDCARD_SUPER_BOUND_SOURCE );
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.