Skip to content

ignoreUnmappedSourceProperties does not propagate via @InheritConfiguration #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RichMacDonald wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ignoreUnmappedSourceProperties does not propagate via @InheritConfiguration #3733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d2d653
Unmapped source properties of the parent do not propagate to the
RichMacDonald Sep 28, 2024
8ec3047
test cleanup
RichMacDonald Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions processor/src/test/java/org/mapstruct/ap/test/bugs/_3248b/Issue3248aMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._3248b;

import org.mapstruct.BeanMapping;
import org.mapstruct.InheritConfiguration;
import org.mapstruct.Mapper;
import org.mapstruct.Mapping;
import org.mapstruct.ReportingPolicy;

/**
* @author RichMacDonald
*
* Adding inheritance to issue 3248
*
* ignoreUnmappedSourceProperties of the parent does not propagate to the subclass via @InheritConfiguration
*
* Diagnostics: [DiagnosticDescriptor: ERROR Issue3248aMapper.java:34
* Unmapped source property: "value1Ignore".]] expected: SUCCEEDED but was: FAILED]
*/
@Mapper(unmappedSourcePolicy = ReportingPolicy.ERROR)
public interface Issue3248aMapper {

@Mapping( target = "value1", source = "value1")
@BeanMapping(ignoreUnmappedSourceProperties = "value1Ignore")
Target1 map1(Source1 source);

@InheritConfiguration
@Mapping( target = "value2", source = "value2")
@BeanMapping(ignoreUnmappedSourceProperties = "value2Ignore")
Target2 map2(Source2 source2); // fails to ignore "value1Ignore"

class Target1 {
private String value1;

public String getValue1() {
return value1;
}

public void setValue1(String value1) {
this.value1 = value1;
}
}

class Source1 {
private String value1;
private String value1Ignore;

public String getValue1() {
return value1;
}

public String getValue1Ignore() {
return value1Ignore;
}
}

class Target2 extends Target1 {
private String value2;

public String getValue2() {
return value2;
}

public void setValue2(String value2) {
this.value2 = value2;
}
}

class Source2 extends Source1 {
private String value2;
private String value2Ignore;

public String getValue2() {
return value2;
}

public String getValue2Ignore() {
return value2Ignore;
}
}
}
25 changes: 25 additions & 0 deletions processor/src/test/java/org/mapstruct/ap/test/bugs/_3248b/Issue3248bTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._3248b;

import org.mapstruct.ap.testutil.IssueKey;
import org.mapstruct.ap.testutil.ProcessorTest;
import org.mapstruct.ap.testutil.WithClasses;

/**
* @author Filip Hrisafov
*/
@IssueKey("3248")
@WithClasses({
Issue3248aMapper.class
})
class Issue3248bTest {

@ProcessorTest
void shouldCompileCode() {

}
}