#598 superclass mapping methods now throw errors/warnings on mapper class.#2608
#598 superclass mapping methods now throw errors/warnings on mapper class.#2608Zegveld wants to merge 0 commit into
Conversation
|
Thanks for the PR @Zegveld. I like the idea. However, I am not to happy with the fact that we have to expose this on the Regarding
Instead of testing it like that I would rather cast to |
|
I agree with that the current solutions isn't the best one, I've been thinking about another way for a while including what you mentioned but so far I haven't been able to get that route working without duplicating a lot of code. Seeing as I'm not a fan of code duplication I'm not willing to put that solution forward. My new idea is to use a decorator pattern on the Originally I tried to use the decorator pattern purely on the Going to work on this idea during the coming weekend, if I have time. (Edit: This PR got automatically closed because I forced the changes away. 😸 ) |
Here is the first (and maybe final) draft of the PR for issue #598. I've made adjustments to the FormattingMessager interface, so this PR will most likely have impact on other PR's that introduce error/warning/info messages during compilation.
FormattingMessager.printMessage now expects 2 elements instead of 1 (those without elements are unaffected):