Skip to content

#2525 add available transformations to CaseEnumTransformationStrategy exception #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiphr merged 2 commits into from
Jul 22, 2021
Merged

#2525 add available transformations to CaseEnumTransformationStrategy exception #2526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3076db2
add available transformations to CaseEnumTransformationStrategy excep…
amogh94 Jul 22, 2021
99cc14b
fix indentation
amogh94 Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion processor/src/main/java/org/mapstruct/ap/spi/CaseEnumTransformationStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public class CaseEnumTransformationStrategy implements EnumTransformationStrateg
private static final String UPPER = "upper";
private static final String LOWER = "lower";
private static final String CAPITAL = "capital";
private static final String CASE_ENUM_TRANSFORMATION_STRATEGIES = UPPER + ", " + LOWER + ", " + CAPITAL;

@Override
public String getStrategyName() {
Expand All @@ -37,7 +38,8 @@ public String transform(String value, String configuration) {
return capitalize( value );
default:
throw new IllegalArgumentException(
"Unexpected configuration for enum case transformation: " + configuration );
"Unexpected configuration for enum case transformation: " + configuration +
". Allowed values: " + CASE_ENUM_TRANSFORMATION_STRATEGIES);
}
}

Expand Down
3 changes: 2 additions & 1 deletion ...va/org/mapstruct/ap/test/value/nametransformation/EnumNameTransformationStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ public void shouldGiveCompileErrorWhenUsingUnknownNameTransformStrategy() {
kind = javax.tools.Diagnostic.Kind.ERROR,
line = 18,
message = "Illegal transformation for 'case' EnumTransformationStrategy." +
" Error: 'Unexpected configuration for enum case transformation: unknown'."
" Error: 'Unexpected configuration for enum case transformation: unknown." +
" Allowed values: upper, lower, capital'."
)
}
)
Expand Down