Skip to content

#2145 fixing 2 step mapping methods (refactoring)#2146

Merged
sjaakd merged 1 commit into
mapstruct:masterfrom
sjaakd:2145
Jul 16, 2020
Merged

#2145 fixing 2 step mapping methods (refactoring)#2146
sjaakd merged 1 commit into
mapstruct:masterfrom
sjaakd:2145

Conversation

@sjaakd

@sjaakd sjaakd commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@sjaakd

sjaakd commented Jul 9, 2020

Copy link
Copy Markdown
Contributor Author

Interesting failure in NullCheckTest.. there are more ways to realize the mapping.. Via long and via int path. Also note: the error message should mention the duplicates..

@sjaakd sjaakd force-pushed the 2145 branch 2 times, most recently from 0f52cb1 to c7dd76c Compare July 13, 2020 21:18
@sjaakd sjaakd changed the title #2145 reproducer #2145 fixing 2 step mapping methods (refactoring) Jul 13, 2020
@sjaakd

sjaakd commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

IS: Total time: 9.036 s
WAS: Total time: 47.051 s

@sjaakd sjaakd requested a review from filiphr July 13, 2020 21:32

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @sjaakd. Looks really good to me. I have only 2 comments / questions

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes

@sjaakd sjaakd merged commit 082db73 into mapstruct:master Jul 16, 2020
filiphr pushed a commit to filiphr/mapstruct that referenced this pull request Jul 17, 2020
@sjaakd sjaakd deleted the 2145 branch August 23, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants