#1742 refactor accessors (make consistent) to have accessed type alwa…#1805
Closed
sjaakd wants to merge 1 commit into
Closed
#1742 refactor accessors (make consistent) to have accessed type alwa…#1805sjaakd wants to merge 1 commit into
sjaakd wants to merge 1 commit into
Conversation
…type always available
Contributor
Author
|
followed up by #1811 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ys available
Currently the accessor type is defined in
PropertyMapperwhile it should be an intrinsic property ofAccessor. Types are fetched and derived in context (again) all-over-the-place.. Sometimes that requires the parent type again and even the mapping method (to derive in context and resolve generics).This PR is the first in a number of refactoring with the goal to have a cleaner separation of concerns.