Improvement: builder for Mapper/Decorator/GeneratedType#1649
Merged
Conversation
filiphr
approved these changes
Nov 17, 2018
filiphr
left a comment
Member
There was a problem hiding this comment.
LGTM.
I have only one comment, but just out of curiosity nothing else. Feel free to merge it when you can
| private Decorator decorator; | ||
|
|
||
| @SuppressWarnings( "checkstyle:parameternumber" ) | ||
| private Mapper(TypeFactory typeFactory, String packageName, String name, String superClassName, |
Contributor
Author
|
Convention? I thought according to jls..
Verstuurd vanaf mijn iPhone
… Op 17 nov. 2018 om 20:54 heeft Filip Hrisafov ***@***.***> het volgende geschreven:
@filiphr approved this pull request.
LGTM.
I have only one comment, but just out of curiosity nothing else. Feel free to merge it when you can
In processor/src/main/java/org/mapstruct/ap/internal/model/Mapper.java:
> @@ -177,6 +112,38 @@ public Mapper build() {
}
+ private final boolean customPackage;
+ private final boolean customImplName;
+ private Decorator decorator;
+
+ @SuppressWarnings( "checkstyle:parameternumber" )
+ private Mapper(TypeFactory typeFactory, String packageName, String name, String superClassName,
Why move the constructor down?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
It's fine, I was just confused, because on other places it is above the builders (I think) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.