Skip to content

fix: grammar in design.md - #4491

Merged
artemp merged 1 commit into
mapnik:masterfrom
SergeCroise:patch-2
Feb 26, 2025
Merged

artemp merged 1 commit into
mapnik:masterfrom
SergeCroise:patch-2

Conversation

@SergeCroise

@SergeCroise SergeCroise commented Feb 7, 2025 •

Copy link
Copy Markdown
Contributor
  • it's up to you ... (instead of its)

see:
https://www.merriam-webster.com/dictionary/its

- it's (instead of its)
@SergeCroise

Copy link
Copy Markdown
Contributor Author

Hello @artemp ,
please review !

@artemp

artemp commented Feb 10, 2025

Copy link
Copy Markdown
Member

Hello @artemp , please review !

@SergeCroise , thanks for attempting to fix typos/spellings etc! It would be better if you could merge individual fixes into one large PR, please.

@SergeCroise

SergeCroise commented Feb 10, 2025 •

Copy link
Copy Markdown
Contributor Author

Hello @artemp , please review !

@SergeCroise , thanks for attempting to fix typos/spellings etc! It would be better if you could merge individual fixes into one large PR, please.

Thank you for reviewing, my intention was to adhere to this best practice:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/helping-others-review-your-changes

@artemp
artemp merged commit 314bd2c into mapnik:master Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants