Skip to content

Semicolon should be used as radiuses and timestamps delimiters #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osana merged 1 commit into from
May 18, 2018
Merged

Semicolon should be used as radiuses and timestamps delimiters #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions services-matching/src/main/java/com/mapbox/api/matching/v5/MapboxMapMatching.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,7 @@ public abstract Builder voiceUnits(
* {@link DirectionsCriteria#ANNOTATION_DISTANCE},
* {@link DirectionsCriteria#ANNOTATION_DURATION},
* {@link DirectionsCriteria#ANNOTATION_DURATION} and
* {@link DirectionsCriteria#ANNOTATION_CONGESTION}. Several annotation can be used by
* separating them with {@code ,}.
* {@link DirectionsCriteria#ANNOTATION_CONGESTION}.
*
* @param annotations string referencing one of the annotation direction criteria's. The strings
* restricted to one or multiple values inside the {@link AnnotationCriteria}
Expand All @@ -529,7 +528,7 @@ public Builder annotations(@Nullable @AnnotationCriteria String... annotations)
/**
* Timestamps corresponding to each coordinate provided in the request; must be numbers in Unix
* time (seconds since the Unix epoch) converted to a String. There must be as many timestamps
* as there are coordinates in the request, each separated by {@code ;} .
* as there are coordinates in the request.
*
* @param timestamps timestamp corresponding to the coordinate added at the identical index
* @return this builder for chaining options together
Expand Down Expand Up @@ -679,9 +678,9 @@ public MapboxMapMatching build() {
}

coordinates(formatCoordinates(coordinates));
timestamps(TextUtils.join(",", timestamps));
timestamps(TextUtils.join(";", timestamps));
annotations(TextUtils.join(",", annotations));
radiuses(TextUtils.join(",", radiuses));
radiuses(TextUtils.join(";", radiuses));
waypoints(TextUtils.join(";", waypoints));

// Generate build so that we can check that values are valid.
Expand Down
4 changes: 2 additions & 2 deletions services-matching/src/test/java/com/mapbox/api/matching/v5/MapboxMapMatchingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public void radiuses_doesShowInUrlCorrectly() throws Exception {
.radiuses(1d, 2d, 3d)
.build();
assertTrue(mapMatching.cloneCall().request().url().toString()
.contains("radiuses=1.0,2.0,3.0"));
.contains("radiuses=1.0;2.0;3.0"));
}

@Test
Expand Down Expand Up @@ -324,7 +324,7 @@ public void timestamps_doesShowInUrlCorrectly() throws Exception {
.timestamps("1", "2", "3")
.build();
assertTrue(mapMatching.cloneCall().request().url().toString()
.contains("timestamps=1,2,3"));
.contains("timestamps=1;2;3"));
}

@Test
Expand Down