Move TurfAssertions.getCoord() to TurfMeta.getCoord() to follow Turf.js#818
Merged
Conversation
cc62a39 to
a0d02fe
Compare
langsmith
reviewed
May 22, 2018
| if (obj.geometry() instanceof Point) { | ||
| return (Point) obj.geometry(); | ||
| } | ||
| throw new TurfException("A feature with a Point geometry is required."); |
langsmith
approved these changes
May 22, 2018
a0d02fe to
46416a8
Compare
cammace
reviewed
May 22, 2018
| * @see <a href="http://turfjs.org/docs/#getcoord">Turf getCoord documentation</a> | ||
| * @since 1.2.0 | ||
| */ | ||
| public static Point getCoord(Feature obj) { |
There was a problem hiding this comment.
This is a semver change, you need to deprecate and point to using the other method instead of deleting it here.
Contributor
Author
There was a problem hiding this comment.
Yes, those need to be fixed also. Sorry for missing that in #738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #816
Also updated https://github.com/mapbox/mapbox-java/blob/master/docs/turf-port.md