Properties passed to Feature.fromGeometry should be Nullable#815
Merged
Conversation
cammace
reviewed
May 10, 2018
| @@ -247,7 +247,10 @@ public static TypeAdapter<Feature> typeAdapter(Gson gson) { | |||
| * @since 1.0.0 | |||
| */ | |||
There was a problem hiding this comment.
Add annotation @Nullable as the return type
Contributor
Author
There was a problem hiding this comment.
I would argue that adding @nullable to toJson is not part of the scope of this Issue, is it?
Contributor
Author
There was a problem hiding this comment.
There are a couple of PRs regarding toJson - so I will address it then
| @@ -247,7 +247,10 @@ public static TypeAdapter<Feature> typeAdapter(Gson gson) { | |||
| * @since 1.0.0 | |||
| */ | |||
| public void addStringProperty(String key, String value) { | |||
There was a problem hiding this comment.
are these params nullable or non, annotate them?
26bce9f to
418dddc
Compare
tobrun
approved these changes
May 24, 2018
…s should be Nullable [#813]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #813