Added cache of type's attributes. #119
Merged
Merged
Conversation
…oncurrency issues (didn't used ConcurrentDictionary because of there is no such in net3.5).
You can solve this with |
sungam3r
reviewed
Oct 22, 2020
Contributor
Author
So, you propose do not add cache for .net 3.5? |
|
I mean you can use 'simple' dictionary for net3.5 and |
Contributor
Author
|
@sungam3r, got it. Used ConcurrentDictionary for all other TFMs. |
sungam3r
reviewed
Oct 28, 2020
manuc66
reviewed
Oct 30, 2020
manuc66
previously approved these changes
Nov 7, 2020
|
I have doubts about |
Owner
|
Published with version 1.9.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cache of type's attributes. This significantly improves performance in case of deserialization of a large amount of data. In my project it decreased time of deserialization of 300k objects from 27s to 7s.
Used double-checked lock to prevent cоncurrency issues. Didn't use ConcurrentDictionary because there is no such in net3.5.