updated layout.js with bright or bold replacer to the pattern option#995
Open
Sebastien-Gutierrez wants to merge 1 commit into
Open
updated layout.js with bright or bold replacer to the pattern option#995Sebastien-Gutierrez wants to merge 1 commit into
Sebastien-Gutierrez wants to merge 1 commit into
Conversation
nomiddlename
requested changes
Apr 19, 2020
Collaborator
nomiddlename
left a comment
There was a problem hiding this comment.
Thanks for putting in this work (and working out how to do a pull request) - if you could add a test that covers this change then we can merge it and get it released. Take a look at the other pattern layout tests and do the same as them. Use npm test to run all the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi All, I was missing the bright/bold option in the pattern. So I added it to the layouts.js script.