Fix to do not cut off multiFile appender code by bundler's tree shaking #1423
Open
nabe1653 wants to merge 2 commits into
Open
Fix to do not cut off multiFile appender code by bundler's tree shaking #1423nabe1653 wants to merge 2 commits into
nabe1653 wants to merge 2 commits into
Conversation
Tried to add sometypes that are not added but listed on the document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to fix #1395 , some appender types are missing from
coreAppendersso tried to add.I don't know correct build/test process but anyway my branch worked with the reproduce code in the issue.
#1411 may have same cause.