Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Remove old basic snapshot transformer and exemptions#9866

Closed
dominikschubert wants to merge 2 commits into
mainfrom
remove-snapshot-exemptions
Closed

Remove old basic snapshot transformer and exemptions#9866
dominikschubert wants to merge 2 commits into
mainfrom
remove-snapshot-exemptions

Conversation

@dominikschubert
Copy link
Copy Markdown
Member

@dominikschubert dominikschubert commented Dec 13, 2023

Motivation

Follow-up to #9772 which introduced an exemption list with paths that are still using the old transformer. This PR can't be merged yet since it will have a lot of CI failures. It should stay open until other PRs have regenerated/fixed the issues in the specific services. Until then it can be rebased and re-run to get an overview of all currently detected issues.

Changes

  • Remove old basis snapshot transformer list & exemption paths

@dominikschubert dominikschubert self-assigned this Dec 13, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Dec 13, 2023
@simonrw simonrw added this to the Playground milestone Jan 22, 2024
@dominikschubert dominikschubert force-pushed the remove-snapshot-exemptions branch from 7051752 to 99ff516 Compare February 11, 2026 10:25
@dominikschubert dominikschubert added notes: skip Pull request does not have to be mentioned in the release notes docs: skip Pull request does not require documentation changes labels Feb 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 140 tests  ±0   21 276 ✅ ±0   6m 16s ⏱️ -16s
     1 suites ±0    1 864 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit dd382fe. ± Comparison against base commit 8cda50b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

LocalStack Community integration with Pro

2 files  ±    0  2 suites  ±0   42s ⏱️ - 1h 57m 7s
3 tests  - 5 200  0 ✅  - 4 851  2 💤  - 349  0 ❌  - 1  1 🔥 +1 
6 runs   - 5 199  0 ✅  - 4 851  4 💤  - 349  0 ❌  - 1  2 🔥 +2 

For more details on these errors, see this check.

Results for commit 99ff516. ± Comparison against base commit 8cda50b.

This pull request removes 5201 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.lambda_.event_source_mapping

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   4 ✅  - 1   3m 12s ⏱️ +13s
1 suites ±0   2 💤 ±0 
1 files   ±0   1 ❌ +1 

For more details on these failures, see this check.

Results for commit dd382fe. ± Comparison against base commit 8cda50b.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 39m 17s ⏱️
5 624 tests 3 349 ✅ 521 💤 1 754 ❌
5 630 runs  3 349 ✅ 527 💤 1 754 ❌

For more details on these failures, see this check.

Results for commit dd382fe.

@alexrashed
Copy link
Copy Markdown
Member

alexrashed commented Feb 24, 2026

@dominikschubert This PR seems a bit outdated, do you think we can close it?

@dominikschubert
Copy link
Copy Markdown
Member Author

dominikschubert commented Feb 27, 2026

I actually recently updated it and it's overall still relevant as the migration hasn't progressed, but willing to recreate it at a later time 👍

@alexrashed alexrashed deleted the remove-snapshot-exemptions branch February 27, 2026 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dominikschubert dominikschubert

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

3 participants

@dominikschubert @alexrashed @simonrw