Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Upgrade travis setup#1445

Merged
whummer merged 1 commit into
localstack:masterfrom
chenrui333:update-travis-config
Aug 13, 2019
Merged

Upgrade travis setup#1445
whummer merged 1 commit into
localstack:masterfrom
chenrui333:update-travis-config

Conversation

@chenrui333
Copy link
Copy Markdown
Contributor

@chenrui333 chenrui333 commented Jul 28, 2019

No description provided.

chenrui333
chenrui333 commented Jul 28, 2019
View reviewed changes
Comment thread .travis.yml
@whummer
Copy link
Copy Markdown
Member

whummer commented Jul 28, 2019

Thanks for tackling this migration @chenrui333 ! Looks like there's still a minor issue with the oracle-java8-installer package not being found.

@chenrui333 chenrui333 changed the title Upgrade travis setup [wip] Upgrade travis setup Jul 28, 2019
@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Jul 28, 2019

yeah, that is right. I will check how to fix that later.

@DavidTanner
Copy link
Copy Markdown
Contributor

DavidTanner commented Aug 9, 2019

I think you will need to switch to openjdk-8-jre-headless

@whummer
Copy link
Copy Markdown
Member

whummer commented Aug 10, 2019

I think you will need to switch to openjdk-8-jre-headless

Thanks @DavidTanner . @chenrui333 can we give that a try?

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 10, 2019

Sure, definitely.

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 10, 2019 

======================================================================
ERROR: Failure: ModuleNotFoundError (No module named 'google_compute_engine')
----------------------------------------------------------------------

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 10, 2019 

[success] 0.01% tests.unit.test_sns_listener.SNSTests.test_create_sns_message_body_raw_message_delivery: 0.0002s
[error] 0.00% <nose.suite.ContextSuite context=tests.integration>:setup: 0.0000s
----------------------------------------------------------------------

looks like integration test suite failed now.

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 10, 2019 •
edited
Loading

@whummer any idea on how to troubleshoot tests.integration failure?

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 11, 2019

Refresh the branch with latest master.

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 11, 2019

Still failing with the tests.integration part.

@DavidTanner
Copy link
Copy Markdown
Contributor

DavidTanner commented Aug 12, 2019

I'm seeing that as an intermittent failure on my branch. It doesn't always fail.

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 12, 2019

So what should be the right way to handle this?

@DavidTanner
Copy link
Copy Markdown
Contributor

DavidTanner commented Aug 12, 2019

It seems to be always an issue with start_sns in infra.py

@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 12, 2019

I see, looks like the build is green now. I will squash some of my changes.

@chenrui333 chenrui333 changed the title [wip] Upgrade travis setup Upgrade travis setup Aug 12, 2019
@chenrui333
Upgrade travis to use py 3.7
26eb872 
Update addon apt repo

Use `openjdk-8-jre-headless` addon pkg

Fix `No module named 'google_compute_engine'`
@chenrui333
Copy link
Copy Markdown
Contributor Author

chenrui333 commented Aug 12, 2019

@whummer, should be good for merge now.

@whummer
Copy link
Copy Markdown
Member

whummer commented Aug 13, 2019

Great, thanks for digging into this @chenrui333 !

@whummer whummer merged commit 540e39c into localstack:master Aug 13, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 14, 2019

Coverage Status

Coverage decreased (-0.1%) to 69.236% when pulling 26eb872 on chenrui333:update-travis-config into e7e2846 on localstack:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenrui333 @whummer @DavidTanner @coveralls