IAM/STS: fix avro compatibility for new providers#13891
Conversation
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 28m 25s ⏱️ Results for commit 957b4b9. |
|
Community integration tests against pro are broken on the parent - I'll rebase it after this is merged. |
bentsku
left a comment
There was a problem hiding this comment.
LGTM, nice workaround 👍
might be worth adding iam and sts to the list of migrated Avro services so you'd get the store police to check it as well 👍
| transitive_tags: list[str] = field(default_factory=list) | ||
| # other stored context variables | ||
| iam_context: dict[str, str | list[str]] = field(default_factory=dict) | ||
| iam_context: dict[str, SingleValuedContextValue | MultiValuedContextValue] = field( |
There was a problem hiding this comment.
question: is this not used anywhere yet? as I cannot see any updated usage
There was a problem hiding this comment.
It’s only used in pro, I adapted it to the in draft iam migration PR
pinzon
left a comment
There was a problem hiding this comment.
Approving. But for the record, I spent some time making an entity for both Virtual and physical MFA. 😅
Motivation
Avro does not allow union of typedicts or union of
str | list[str].This PR clarifies those usages to avoid serialization issues.
Changes
Tests
Related
Closes UNC-335