Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Implement IAM account aliases#13855

Merged
dfangl merged 1 commit into
iam/moto-migrationfrom
daniel/unc-300
Feb 26, 2026
Merged

Implement IAM account aliases#13855
dfangl merged 1 commit into
iam/moto-migrationfrom
daniel/unc-300

Conversation

@dfangl

@dfangl dfangl commented Feb 26, 2026

Copy link
Copy Markdown
Member

Motivation

We forgot to migrate IAM account aliases so far, this PR migrates that feature!

Changes

  • Add the create, list and delete methods. They are very barebones, similar to the moto implementation.

Tests

  • test_account_alias_lifecycle is passing

Related

Closes UNC-300

@dfangl dfangl requested a review from pinzon as a code owner February 26, 2026 14:44
@dfangl dfangl added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 26, 2026
@github-actions

Copy link
Copy Markdown

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   3m 2s ⏱️ - 2h 3m 15s
520 tests  - 5 114  503 ✅  - 4 752  11 💤  - 361  6 ❌  - 1 
522 runs   - 5 114  503 ✅  - 4 752  13 💤  - 361  6 ❌  - 1 

For more details on these failures, see this check.

Results for commit 39e1703. ± Comparison against base commit 4b158e1.

@github-actions

github-actions Bot commented Feb 26, 2026

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 070 tests  ±0   21 179 ✅ ±0   6m 13s ⏱️ -17s
     1 suites ±0    1 891 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 39e1703. ± Comparison against base commit 4b158e1.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 13s ⏱️ +11s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 39e1703. ± Comparison against base commit 4b158e1.

@github-actions

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   11m 48s ⏱️ - 2h 49m 12s
544 tests  - 5 495  526 ✅  - 4 978  11 💤  - 517  7 ❌ ±0 
550 runs   - 5 495  526 ✅  - 4 978  17 💤  - 517  7 ❌ ±0 

For more details on these failures, see this check.

Results for commit 39e1703. ± Comparison against base commit 4b158e1.

@pinzon pinzon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for realizing this. There is a failing IAM test but it's unrelated to this change. 👍

Comment on lines +5036 to +5038
store = self._get_store(context)
aliases = [store.ACCOUNT_ALIAS] if store.ACCOUNT_ALIAS else []
return ListAccountAliasesResponse(AccountAliases=aliases, IsTruncated=False)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@dfangl dfangl merged commit 1751aaf into iam/moto-migration Feb 26, 2026
54 of 61 checks passed
@dfangl dfangl deleted the daniel/unc-300 branch February 26, 2026 16:41
dfangl added a commit that referenced this pull request Feb 26, 2026
dfangl added a commit that referenced this pull request Mar 4, 2026
dfangl added a commit that referenced this pull request Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants