Implement CredentialsReport, AccountSummary and AccountAuthorizationDetails#13845
Conversation
LocalStack Community integration with Pro 2 files 2 suites 3m 7s ⏱️ For more details on these failures, see this check. Results for commit f426f44. |
Test Results (amd64) - Integration, Bootstrap 5 files ± 0 5 suites ±0 11m 54s ⏱️ - 2h 29m 42s For more details on these failures, see this check. Results for commit f426f44. ± Comparison against base commit cf50738. |
|
|
||
| @markers.aws.validated | ||
| def test_get_credential_report_before_generated(self, aws_client, create_user, snapshot): | ||
| """This test can ONLY be executed once per account. Be careful!""" |
| # Check if a report already exists and is not older than 4 hours | ||
| if store.CREDENTIAL_REPORT is not None and datetime.now( | ||
| UTC | ||
| ) - store.CREDENTIAL_REPORT.generated_at < timedelta(hours=4): | ||
| return GenerateCredentialReportResponse(State=ReportStateType.COMPLETE) |
There was a problem hiding this comment.
Question: Should we really emulate the 4 hours limitation? Maybe we could write a config var to disable this behavior. Of course, this should be fine for the migration but we should revisit this later.
There was a problem hiding this comment.
It is a good question - I think we need to see what the user requirements are in the future. For now, I think choosing parity is a good idea. We could introduce a config to configure the timeout, or even add an endpoint resetting it!
Motivation
Migrating the IAM credentials reports, account summary and authorization details.
Changes
Tests
Related
Closes UNC-276