Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Migrate IAM policy simulator#13843

Merged
dfangl merged 1 commit into
iam/moto-migrationfrom
daniel/unc-296
Feb 26, 2026
Merged

Migrate IAM policy simulator#13843
dfangl merged 1 commit into
iam/moto-migrationfrom
daniel/unc-296

Conversation

@dfangl

@dfangl dfangl commented Feb 25, 2026

Copy link
Copy Markdown
Member

Motivation

With the migration to LocalStack, the IAM basic policy simulation ceases to work.
This PR reintegrates it with the current model.

Currently the implementation uses some private methods from the provider - this will be refactored separately, once all of the bigger work is in!

Changes

  • Modify to use the stores to look up policies / principals.

Tests

IAM policy simulator tests now pass

Related

Closes UNC-296

@dfangl dfangl requested a review from pinzon as a code owner February 25, 2026 14:51
@dfangl dfangl added this to the 2026.03 milestone Feb 25, 2026
@dfangl dfangl added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 25, 2026
@github-actions

Copy link
Copy Markdown

LocalStack Community integration with Pro

  2 files    2 suites   2m 37s ⏱️
520 tests 482 ✅ 32 💤 6 ❌
522 runs  482 ✅ 34 💤 6 ❌

For more details on these failures, see this check.

Results for commit 3513fdb.

@github-actions

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 123 tests  +53   21 252 ✅ +73   6m 43s ⏱️ +31s
     1 suites ± 0    1 871 💤  - 20 
     1 files   ± 0        0 ❌ ± 0 

Results for commit 3513fdb. ± Comparison against base commit 4cc1683.

@github-actions

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 5s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3513fdb. ± Comparison against base commit 4cc1683.

@github-actions

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   11m 28s ⏱️ - 2h 28m 42s
544 tests  - 5 495  506 ✅  - 4 973  32 💤  - 517  6 ❌  - 5 
550 runs   - 5 495  506 ✅  - 4 973  38 💤  - 517  6 ❌  - 5 

For more details on these failures, see this check.

Results for commit 3513fdb. ± Comparison against base commit 4cc1683.

@pinzon pinzon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dfangl dfangl merged commit b1990ab into iam/moto-migration Feb 26, 2026
39 of 43 checks passed
@dfangl dfangl deleted the daniel/unc-296 branch February 26, 2026 09:15
dfangl added a commit that referenced this pull request Feb 26, 2026
dfangl added a commit that referenced this pull request Feb 26, 2026
dfangl added a commit that referenced this pull request Mar 4, 2026
dfangl added a commit that referenced this pull request Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants