This repository was archived by the owner on Mar 23, 2026. It is now read-only.
IAM: Migrate server and signing certificates#13840
Merged
Merged
Conversation
LocalStack Community integration with Pro 2 files 2 suites 2m 48s ⏱️ For more details on these failures, see this check. Results for commit dfd4cef. |
Test Results (amd64) - Integration, Bootstrap 5 files ± 0 5 suites ±0 11m 18s ⏱️ - 2h 28m 52s For more details on these failures, see this check. Results for commit dfd4cef. ± Comparison against base commit 4cc1683. |
pinzon
approved these changes
Feb 25, 2026
Comment on lines
+3543
to
+3553
| def _generate_server_certificate_id(self, context: RequestContext) -> str: | ||
| """Generate a server certificate ID with ASCA prefix.""" | ||
| return generate_iam_identifier(context.account_id, prefix="ASCA", total_length=21) | ||
|
|
||
| def _build_server_certificate_arn( | ||
| self, context: RequestContext, path: str, cert_name: str | ||
| ) -> str: | ||
| """Build the ARN for a server certificate.""" | ||
| return ( | ||
| f"arn:{context.partition}:iam::{context.account_id}:server-certificate{path}{cert_name}" | ||
| ) |
Member
There was a problem hiding this comment.
comment: these 2 methods could be placed in the "utils" file.
Comment on lines
+3811
to
+3814
| def _generate_signing_certificate_id(self) -> str: | ||
| """Generate a 24-character signing certificate ID (uppercase alphanumeric).""" | ||
| return "".join(random.choices(string.ascii_uppercase + string.digits, k=24)) | ||
|
|
dfangl
added a commit
that referenced
this pull request
Feb 26, 2026
dfangl
added a commit
that referenced
this pull request
Feb 26, 2026
dfangl
added a commit
that referenced
this pull request
Mar 4, 2026
dfangl
added a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Next, we are migrating the IAM server and signing certificates.
Changes
Server Certificates (8 operations)
UploadServerCertificateGetServerCertificateListServerCertificatesDeleteServerCertificateUpdateServerCertificateTagServerCertificateUntagServerCertificateListServerCertificateTagsSigning Certificates (4 operations)
UploadSigningCertificateListSigningCertificatesUpdateSigningCertificateDeleteSigningCertificateEntity Storage
Server Certificates:
ServerCertificateEntitydataclass wrapping the API'sServerCertificateMetadataIamStore.SERVER_CERTIFICATESdict keyed by certificate nameCrossRegionAttributesince IAM is a global serviceSigning Certificates:
SigningCertificateTypedDict directly (no wrapper needed)UserEntity.signing_certificatesdict keyed by certificate IDLimitExceededException)Tests
All 7 tests pass with snapshot parity:
test_server_certificate_lifecycle[None]✅test_server_certificate_lifecycle[/]✅test_server_certificate_lifecycle[/test-path/]✅test_server_certificate_with_chain✅test_server_certificate_errors✅test_signing_certificate_lifecycle✅test_signing_certificate_errors✅Related
Closes UNC-292